HomePhabricator
Diffusion Comm 7890c358db05

[lib] introduce unshimMessageInfo to reaction message spec

Description

[lib] introduce unshimMessageInfo to reaction message spec

Summary:
introduce unshimMessageInfo to reaction message spec. unshimMessageInfo handles the unshimming of unsuported messages to a supported message by simply returning the unwrapped messageinfo of the previously unsupported message"


Depends on D5690
Linear Task: ENG-2245

Test Plan:
Ran web and mobile app locally and nothing crashes/will be doing more tests on this message spec in subsequent diffs. Also in my local stack, (with some extra code that will come in subsequent diffs) I was able to get a reaction message to "unshim" which I feel is a strong indicator that this function works as expected (see screenshots below)

Reaction Message when unsupported:

Screenshot 2022-11-28 at 11.24.26 AM.png (1×1 px, 826 KB)

Reaction Message when supported:

Screenshot 2022-12-02 at 4.56.02 PM.png (1×1 px, 857 KB)

Reviewers: atul, rohan, tomek

Reviewed By: atul, tomek

Subscribers: ashoat, tomek, atul

Differential Revision: https://phab.comm.dev/D5805

Details

Provenance
ginsuAuthored on Dec 15 2022, 12:24 PM
Reviewer
atul
Differential Revision
D5805: [lib] introduce unshimMessageInfo to reaction message spec
Parents
rCOMM45beae3d9b2f: [lib] introduced rawMessageInfoFromMessageData function to reaction message spec
Branches
Unknown
Tags
Unknown