HomePhabricator
Diffusion Comm 7a608523bf85

[native] Make sure all virtual classes in C++ code base have virtual destructor
7a608523bf85
Actions

Description

[native] Make sure all virtual classes in C++ code base have virtual destructor

Summary: https://linear.app/comm/issue/ENG-2329/make-sure-all-virtual-classes-in-c-code-base-have-virtual-destructor

Test Plan: Compile the app and make sure there are no more warnings related to missing virtual destructors

Reviewers: kamil, tomek

Reviewed By: kamil

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D13950

Details

Provenance
angelikaAuthored on Fri, Nov 15, 1:24 PM
Reviewer
kamil
Differential Revision
D13950: [native] Make sure all virtual classes in C++ code base have virtual destructor
Parents
rCOMMd3f8dfe50344: [native] Increase expansion button tap target in community side drawer
Branches
Unknown
Tags
Unknown

Changes (3)

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
NativeModules/
PersistentStorageUtilities/
MessageOperationsUtilities/
MessageSpecs/
web/
shared-worker/
_generated/

rCOMM7a608523bf85

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/MessageSpec.h

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...