HomePhabricator
Diffusion Comm 80362d917dcf

[Keyserver] Migrate to non-apache config, update native

Description

[Keyserver] Migrate to non-apache config, update native

Summary:
Use keyserver migration logic to apply developoment defaults which
work without use of Apache.

Update native url logic to account for explicit port usage

https://linear.app/comm/issue/ENG-2260

Test Plan:
First need to create an existing app, which uses the apache configuration

git checkout master
nix develop # optional, if legacy dev env already applied

# In one terminal
cd keyserver
yarn dev

# In another terminal
cd native
yarn dev

# Run follwoing command in another terminal
yarn react-native run-ios --simulator='iPhone 14 Pro' --configuration=Debug

# Should be able to do normal iOS Dev workflow:
#   No "DISCONNECTED" bar appears, able to create chat threads
#   Profile > Developer tools, should show http://localhost/comm

Screen Shot 2022-12-19 at 6.44.48 AM.png (594×698 px, 66 KB)

Next, we need apply url-utils changes:

arc patch D5846

# Keyserver should apply the migration, but still needs to restart for routing changes
# restart `yarn dev` in `keyserver/`

# App should update to new defaultURL without intervention, but to start it again
yarn react-native run-ios --simulator='iPhone 14 Pro' --configuration=Debug
# Should be able to do normal iOS Dev workflow:
#   No "DISCONNECTED" bar appears, able to create chat threads
#   Profile > Developer tools, should show http://localhost:3000/comm

Screen Shot 2022-12-19 at 6.47.07 AM.png (604×660 px, 65 KB)

Reviewers: atul, varun, ashoat

Reviewed By: ashoat

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D5846

Details

Provenance
jonAuthored on Dec 8 2022, 11:04 AM
Reviewer
ashoat
Differential Revision
D5846: [Keyserver] Migrate to non-apache config, update native
Parents
rCOMM1215b1079ad5: [Nix] Add script to start/stop tunnelbroker services
Branches
Unknown
Tags
Unknown