HomePhabricator
Diffusion Comm 8330dbc8e2ff

[web] Introduce search modal component

Description

[web] Introduce search modal component

Summary:
We're going to have a couple of modals that have search functionality, so it makes sense to have a component for that.
We usually prefer using children components when introducing containers like this, but in this case that approach has a couple of disadvantages: we would need to pass searchText to children as a prop and that would require using React.cloneElement. Also, defining child component props would be complicated to allow supporting all the components that have searchText props. None of these are too serious, but it looks like using children function is more readable and easier approach. If you disagree, it can easily be modified.
Depends on D3385

Test Plan: Open members modal and check if filtering works correctly.

Reviewers: benschac, atul, def-au1t

Reviewed By: benschac, atul, def-au1t

Subscribers: ashoat, Adrian, karol-bisztyga

Differential Revision: https://phabricator.ashoat.com/D3494

Details

Provenance
tomekAuthored on Mar 23 2022, 7:30 AM
Reviewer
benschac
Differential Revision
D3494: [web] Introduce search modal component
Parents
rCOMM8c887ebc7fb9: [lib] New action to fetch single message for a list of threads
Branches
Unknown
Tags
Unknown