HomePhabricator
Diffusion Comm 847cb1f21c04

Put collapse key in encrypted MacOS notification payload

Description

Put collapse key in encrypted MacOS notification payload

Summary:
This differential fixes urget issue:
https://linear.app/comm/issue/ENG-6010/invariant-violation-collapsible-notifications-encryption-currently-not.
We want to keep the invariant active since it protects us against accidentally exposing unencrypted
collapseID in notification headers. We just need to put it in notification payload for MacOS notifs as well.
Putting collapseID in notification.collapseID results in collapseID being exposed in notification
headers. Putting it in notification.payload results in collapseID being encrypted.

Test Plan:

  1. Build MacOS desktop app.
  2. Send collapsible notifications (chenge the color of the thread for instance).
  3. Ensure that notifications are displayed correctly and version field in MariaDB of relevant olm session

is incremented with each notification.

Reviewers: michal, kamil

Reviewed By: michal

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D10188

Details

Provenance
marcinAuthored on Dec 4 2023, 11:16 PM
Reviewer
michal
Differential Revision
D10188: Put collapse key in encrypted MacOS notification payload
Parents
rCOMM63656c7ad703: [lib] Fix pinned messages not working
Branches
Unknown
Tags
Unknown