HomePhabricator
Diffusion Comm 8ac08973258f

[lib/keyserver] add check to make sure users cannot send reactions from the…

Description

[lib/keyserver] add check to make sure users cannot send reactions from the source message of a sidebar

Summary: While working on improving message liking, came across this edge case where users were able to react to the source message of a sidebar. We shouldn't allow users to do this, so I implemented a check on the client and keyserver to ensure we catch this behavior. In regards to displaying the reactions for the source message from the original thread to the sidebar thread, this linear task tracks this work and is something we will be addressing in the near future.

Test Plan:
Please watch the demo videos to see the changes I made:

Before:

After:

Reviewers: atul, tomek, ashoat

Reviewed By: ashoat

Subscribers: ashoat, tomek, atul

Differential Revision: https://phab.comm.dev/D6004

Details

Provenance
ginsuAuthored on Dec 29 2022, 9:05 AM
Reviewer
ashoat
Differential Revision
D6004: [lib/keyserver] add check to make sure users cannot send reactions from the source message of a sidebar
Parents
rCOMMe01e78fb8b04: [native] Reverting D5999 and D6000
Branches
Unknown
Tags
Unknown