HomePhabricator
Diffusion Comm 8b43f2e9f4b9

[server] Use baseRoutePath in getAppURLFactsFromRequestURL

Description

[server] Use baseRoutePath in getAppURLFactsFromRequestURL

Summary:
baseRoutePath is the internal one, and req.url represents Node's internal path. basePath refers to the public (Apache) path.

Depends on D3552

Test Plan:

  1. We tested the landing page, the SquadCal app, and the Comm app
  2. We made sure we tried configs where baseRoutePath !== basePath
  3. We also checked view-source to make sure things were set correctly
  4. We made sure there were no errors in the browser console
  5. We played around with the site, logging in and navigating and making sure things worked correctly
  6. We tried loading a specific URL for a specific chat directly

Reviewers: varun, atul, palys-swm

Reviewed By: varun

Subscribers: Adrian, karol-bisztyga, benschac, yayabosh

Differential Revision: https://phabricator.ashoat.com/D3553

Details

Provenance
ashoatAuthored on Mar 29 2022, 2:55 PM
Reviewer
varun
Differential Revision
D3553: [server] Use baseRoutePath in getAppURLFactsFromRequestURL
Parents
rCOMMddc6ae7478e5: [server] Use same Router config for web.comm.app that we use for squadcal.org
Branches
Unknown
Tags
Unknown