HomePhabricator
Diffusion Comm 90e5699676fb

Introduce changes to Session.cpp that allow to decrypt with session object alone

Description

Introduce changes to Session.cpp that allow to decrypt with session object alone

Summary:
This differential refactors CryptoModule and Session objects. The following changes are introduced:

  1. Session object doesn't hold reference to CryptoModule anymore. This reference was just passed in constructor and never used in any method.
  2. Session object can decrypt message independently.
  3. CryptoModule can remove session from its internal map.

All changes above were necessary to enable notifications code to work with sessions objects only.

Test Plan: Text that encrypted notifs work correctly.

Reviewers: kamil, tomek, michal

Reviewed By: kamil

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D11233

Details

Provenance
marcinAuthored on Feb 20 2024, 6:23 AM
Reviewer
kamil
Differential Revision
D11233: Introduce changes to Session.cpp that allow to decrypt with session object alone
Parents
rCOMMd5b14c070cef: Introduce notifications crypto module to CommCoreModule
Branches
Unknown
Tags
Unknown