HomePhabricator
Diffusion Comm 92a8efadedbf

[lib] Replace `threadMemberHasPermission` logic in `appendUserInfo`

Tags
None
Referenced Files
F1918358: 053044.png
Jun 11 2024, 1:22 PM
File Not Attached
F1918357: d7f5e7.png
Jun 11 2024, 1:22 PM
File Not Attached
Subscribers
None

Description

[lib] Replace threadMemberHasPermission logic in appendUserInfo

Summary:
Instead of checking KNOW_OF using threadMemberHasPermission which requires member.permissions for all members, we use the member's role permissions to determine if they have KNOW_OF.

This was the one usage of threadMemberHasPermission, so now it can be fully removed as well.


Depends on D12158

Test Plan:
Added log statements at each step and ensured that values were as expected:

d7f5e7.png (1×1 px, 309 KB)

053044.png (622×2 px, 329 KB)

Reviewers: ashoat, tomek, varun, ginsu

Reviewed By: ashoat

Differential Revision: https://phab.comm.dev/D12259

Details

Provenance
atulAuthored on Jun 11 2024, 1:19 PM
Reviewer
ashoat
Differential Revision
D12259: [lib] Replace `threadMemberHasPermission` logic in `appendUserInfo`
Parents
rCOMMd626ec3e0a61: [lib] introduce new updateRolesAndPermissions migration util
Branches
Unknown
Tags
Unknown