HomePhabricator
Diffusion Comm 956303ff887a

Enable encrypted notifications coalescing on in Androoid native code.

Description

Enable encrypted notifications coalescing on in Androoid native code.

Summary:
Notification coalescing on Android is done automatically when we pass to NotificationManager.notify() and id that has been passed previously. The OS replaces the previous notification with the new one. That said to support encrypted notifications coalescing we have to:

  1. Always provide brand id field of the notification.
  2. Put the collapseKey in the encrypted notification payload.
  3. One the device look for the collapseKey in the payload after decryption and use it instead of id in case it is present.

Test Plan:

  1. Build Android app.
  2. Apply this patch to the keyserver: https://gist.github.com/marcinwasowicz/4a794560ef7cdac30dc15da75918a99d
  3. Test that notifications like chat description update are correctly coalesced.

Reviewers: tomek, atul, bartek

Reviewed By: tomek

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D9198

Details

Provenance
marcinAuthored on Sep 14 2023, 2:28 AM
Reviewer
tomek
Differential Revision
D9198: Enable encrypted notifications coalescing on in Androoid native code.
Parents
rCOMM80d2d4888f72: Encrypt all notifications on the keyserver for iOS devices
Branches
Unknown
Tags
Unknown