HomePhabricator
Diffusion Comm 960e1bb5401c

[RN72][skip-ci] Manual ESLint fixes

Description

[RN72][skip-ci] Manual ESLint fixes

Summary:
These fixes had to be applied manually. They are in three categories:

  1. Prettier has deprecated support for Flow comment syntax. Running Prettier on code that includes Flow comment syntax results in those comments being stripped, which doesn't work for us. To get around this, I added some prettier-ignore annotations. I also tested and confirmed that we still can't use prettier-ignore for the import type declaration at the top of services/electron-update-server/index.js.
  2. The react/no-deprecated rule is now flagging our usage of the deprecated ReactDOMServer.renderToNodeStream utility. Migrating to ReactDOMServer.renderToPipeableStream is tracked in ENG-2512.
  3. The react/jsx-key rule started flagging the updated code in native/avatars/avatar-hooks.js. I don't think this list is actually rendered directly by the @expo/react-native-action-sheet code, so the key prop isn't really necessary. But I figured that it doesn't hurt it anyways.

Depends on D10539

Test Plan: Run yarn eslint:fix from the repo root and confirm no errors are printed and no changes are made

Reviewers: atul

Reviewed By: atul

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D10540

Details

Provenance
ashoatAuthored on Jan 3 2024, 11:16 AM
Reviewer
atul
Differential Revision
D10540: [RN72][skip-ci] Manual ESLint fixes
Parents
rCOMMf3271476a57a: [RN72][skip-ci] Automatic Prettier fixes
Branches
Unknown
Tags
Unknown