HomePhabricator
Diffusion Comm 96701d4d30c4

[lib] modify `assertObjectsAreEqual` to return deep differential instead of…

Tags
None
Referenced Files
F529476: image.png
May 30 2023, 3:36 AM
File Not Attached
F529475: image.png
May 30 2023, 3:36 AM
File Not Attached
Subscribers
None

Description

[lib] modify assertObjectsAreEqual to return deep differential instead of only one level keys

Summary:
Previously, when keys were the same logging wasn't saying much:

image.png (248×287 px, 62 KB)

Now it shows not only missing keys but diff on each object level:

image.png (299×271 px, 77 KB)

Depends on D7753

Test Plan:

  1. Check if this not cause errors on equal objects
  2. Check if this shows detailed information what are the differences between objects

Reviewers: tomek, michal

Reviewed By: michal

Subscribers: ashoat, atul

Differential Revision: https://phab.comm.dev/D7754