HomePhabricator
Diffusion Comm 9aaf6daf05bc

[terraform] change protocol version from grpc -> http2

Description

[terraform] change protocol version from grpc -> http2

Summary:
changed the load balancer target group from GRPC to HTTP2 to resolve the grpc-web issues on staging.

safari and chrome were able to adapt to HTTP2 and so requests succeeded. normal gRPC requests from native still work, too.

one issue, though, is that older browsers that don't support HTTP2 won't be able to run the web app

Browsers with limited HTTP/2 support:

  • Internet Explorer 11 (limited support for specific features, unclear what these feature are, though)
  • Older versions of Android WebView (prior to version 47)

Browsers with no HTTP/2 support:

  • Internet Explorer 10 and earlier
  • Older versions of iOS Safari (prior to version 9)
  • Older versions of Android Browser (prior to version 5)

Another possible solution is to introduce a new aws_lb_listener that listens on a different port (say, 50057) for HTTP/1.1 requests, but this solution is a little more involved. If we think this is the right way to go, I can revise this diff.

Test Plan:
used the grpc-web client to send generateNonce requests to staging successfully on chrome and safari, tested
normal grpc requests on native to make sure they still work

Reviewers: bartek, ashoat

Reviewed By: bartek, ashoat

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D10299

Details

Provenance
varunAuthored on Dec 11 2023, 9:51 PM
Reviewer
bartek
Differential Revision
D10299: [terraform] change protocol version from grpc -> http2
Parents
rCOMMc7cbe918dad2: [lib] Prevent the influx of SEARCH_USERS_[STARTED/SUCCESS] actions
Branches
Unknown
Tags
Unknown