HomePhabricator
Diffusion Comm 9cc179609fac

[services] Rust Integration - Backup - Stop rethrowing in send log reactor

Description

[services] Rust Integration - Backup - Stop rethrowing in send log reactor

Summary:
Depends on D5026

Linear task: https://linear.app/comm/issue/ENG-1727/catch-stdexception-in-base-reactors

We started using rust, and we use functions that return Result. That Result is then converted into a std::exception in c++ when it returns Err. All over the place in the reactors we handle std::runtime_errors but we should go higher in the hierarchy and catch std::exceptions.

Here, I removed rethrowing in send log reactor as it is caught in the base reactors (earlier in this stack).

Test Plan:

cd services
yarn run-integration-tests backup

Works as before (of course, you have to start backup and blob services first).

Reviewers: jon, tomek, max

Reviewed By: tomek

Subscribers: ashoat, tomek, atul, abosh

Differential Revision: https://phab.comm.dev/D5027