Page MenuHomePhabricator

[services] Rust Integration - Catch std::exception in base write reactor
ClosedPublic

Authored by karol on Sep 1 2022, 11:53 PM.
Tags
None
Referenced Files
F2101613: D5026.id.diff
Mon, Jun 24, 10:40 PM
F2097762: D5026.id16455.diff
Mon, Jun 24, 11:26 AM
Unknown Object (File)
Sat, Jun 22, 6:30 AM
Unknown Object (File)
Fri, Jun 21, 8:53 AM
Unknown Object (File)
Sat, Jun 15, 10:52 AM
Unknown Object (File)
Thu, Jun 13, 9:25 PM
Unknown Object (File)
Tue, May 28, 3:13 AM
Unknown Object (File)
Sun, May 26, 8:15 PM

Details

Summary

Depends on D5025

Linear task: https://linear.app/comm/issue/ENG-1727/catch-stdexception-in-base-reactors

We started using rust, and we use functions that return Result. That Result is then converted into a std::exception in c++ when it returns Err. All over the place in the reactors we handle std::runtime_errors but we should go higher in the hierarchy and catch std::exceptions.

Test Plan
cd services
yarn run-integration-tests backup

Works as before (of course, you have to start backup and blob services first).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 5 2022, 7:29 AM
This revision was landed with ongoing or failed builds.Sep 8 2022, 4:10 AM
This revision was automatically updated to reflect the committed changes.