Differential D5018

[services] Backup - Use Blob client in c++ - Implement add attachment
ClosedPublic
Actions

Authored by • karol on Sep 1 2022, 4:10 AM.

Tags

None

Referenced Files

	F3331317: D5018.id.diff
	Wed, Nov 20, 8:17 PM

	Unknown Object (File)
	Tue, Nov 12, 7:54 AM

	Unknown Object (File)
	Mon, Nov 11, 11:55 AM

	Unknown Object (File)
	Sun, Nov 10, 6:57 AM

	Unknown Object (File)
	Sun, Nov 3, 2:47 AM

	Unknown Object (File)
	Tue, Oct 29, 4:22 PM

	Unknown Object (File)
	Sun, Oct 27, 8:12 PM

	Unknown Object (File)
	Sun, Oct 27, 8:12 PM

Subscribers

Details

Reviewers

• jon
tomek
• max

Commits

rCOMM0b822963c7ec: [services] Backup - Use Blob client in c++ - Implement add attachment

Summary

Depends on D5017

Adding c++ implementation for using the blob client in the backup reactor for adding attachments.

Test Plan

backup builds

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Sep 1 2022, 4:10 AM

Herald added a reviewer: • jon. · View Herald TranscriptSep 1 2022, 4:10 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• karol edited the summary of this revision. (Show Details)Sep 1 2022, 4:26 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max.

• karol added a parent revision: D5017: [services] Backup - Use Blob client in c++ - Implement create new backup.

• karol added a child revision: D5019: [services] Backup - Use Blob client in c++ - Implement send log.

Harbormaster completed remote builds in B11775: Diff 16178.Sep 1 2022, 4:29 AM

• karol requested review of this revision.Sep 1 2022, 4:29 AM

• karol planned changes to this revision.Sep 2 2022, 5:47 AM

rebase

Harbormaster failed remote builds in B11841: Diff 16246!Sep 2 2022, 5:52 AM

tomek requested changes to this revision.Sep 5 2022, 5:56 AM

tomek added inline comments.

services/backup/src/Reactors/server/AddAttachmentsUtility.cpp
78–80 ↗	(On Diff #16246)	Doesn't seem like parentheses pair here. backup builds Are you sure?

This revision now requires changes to proceed.Sep 5 2022, 5:56 AM

fix

services/backup/src/Reactors/server/AddAttachmentsUtility.cpp
78–80 ↗	(On Diff #16246)	ok thx not sure how this happened, will fix

Harbormaster completed remote builds in B11912: Diff 16355.Sep 6 2022, 3:32 AM

remove the comments

remove comments

tomek accepted this revision.Sep 7 2022, 5:24 AM

tomek added inline comments.

services/backup/src/Reactors/server/AddAttachmentsUtility.cpp
81 ↗	(On Diff #16396)	Is there a downside of calling one write after another without the read between them?

This revision is now accepted and ready to land.Sep 7 2022, 5:24 AM

• karol added inline comments.Sep 8 2022, 3:48 AM

services/backup/src/Reactors/server/AddAttachmentsUtility.cpp
81 ↗	(On Diff #16396)	I think I explained this in another task. Anyway, the thing is, this is how grpc works, it yields a response even if it is empty. Our response queue is limited to 1 (after that, it will hang), so we should always read using the bidi stream, no matter if we use the response or not. We can, of course, add additional logic that would automatically discard responses.

rebase

Harbormaster failed remote builds in B11995: Diff 16450!Sep 8 2022, 4:09 AM

This revision was landed with ongoing or failed builds.Sep 8 2022, 4:10 AM

Closed by commit rCOMM0b822963c7ec: [services] Backup - Use Blob client in c++ - Implement add attachment (authored by • karol). · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM0b822963c7ec: [services] Backup - Use Blob client in c++ - Implement add attachment.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

Reactors/

server/

AddAttachmentsUtility.cpp

25 lines

Diff 16477

services/backup/src/Reactors/server/AddAttachmentsUtility.cpp

Loading...