Page MenuHomePhabricator
Differential D5097

[services] Backup - Blob Get Client - Cleanup
ClosedPublic
Actions

Authored by • karol on Sep 9 2022, 4:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 19, 1:49 PM
Unknown Object (File)
Sun, Mar 16, 12:39 AM
Unknown Object (File)
Wed, Mar 12, 9:55 PM
Unknown Object (File)
Sat, Mar 8, 10:36 PM
Unknown Object (File)
Sat, Mar 8, 8:36 PM
Unknown Object (File)
Fri, Mar 7, 2:24 AM
Unknown Object (File)
Thu, Mar 6, 10:23 PM
Unknown Object (File)
Thu, Mar 6, 5:18 AM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
• jon
• max
varun
tomek
Commits
rCOMM37af4e6583b9: [services] Backup - Blob Get Client - Cleanup
Summary

Depends on D5096

Linear task: https://linear.app/comm/issue/ENG-1734/improve-error-handling-system-in-the-blob-client

Removing ERROR_MESSAGES in both client.

For the put client, deferring handling an error to only one place in the code.

Test Plan
cd services/backup/blob_client
cargo check

after running localstack, blob, and backup (in this particular order), this still works:

yarn run-integration-tests backup
yarn run-performance-tests backup

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Sep 9 2022, 4:44 AM
Herald added a reviewer: • jon. · View Herald TranscriptSep 9 2022, 4:45 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript
• karol edited the summary of this revision. (Show Details)Sep 9 2022, 4:55 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: • max, varun, tomek.
• karol added a parent revision: D5096: [services] Backup - Blob Get Client - Refactor put initialize.
• karol edited the test plan for this revision. (Show Details)Sep 9 2022, 4:58 AM
Harbormaster completed remote builds in B12050: Diff 16549.Sep 9 2022, 4:59 AM
• karol requested review of this revision.Sep 9 2022, 4:59 AM
• karol added a child revision: D5098: [services] Rust Integration - Backup - Rust - Fix backup utils.Sep 9 2022, 7:09 AM
• jon accepted this revision.Sep 9 2022, 10:38 AM

better than panic'ing

This revision is now accepted and ready to land.Sep 9 2022, 10:38 AM
• karol mentioned this in D5096: [services] Backup - Blob Get Client - Refactor put initialize.Sep 12 2022, 1:07 AM
• karol updated this revision to Diff 16571.Sep 12 2022, 1:17 AM
• karol edited the summary of this revision. (Show Details)

update

Harbormaster completed remote builds in B12071: Diff 16571.Sep 12 2022, 1:27 AM
• karol added a child revision: D5099: [services] Backup - Blob Get Client - Pass rust string instead of const char*.Sep 13 2022, 1:09 AM
• karol updated this revision to Diff 16689.Sep 15 2022, 1:28 AM

rebase

Harbormaster completed remote builds in B12161: Diff 16689.Sep 15 2022, 1:40 AM
tomek accepted this revision.Sep 15 2022, 9:00 AM
tomek added inline comments.
services/backup/blob_client/src/put_client.rs
185–188 ↗(On Diff #16689)

The formatting should be done earlier in the stack

• karol updated this revision to Diff 16846.Sep 19 2022, 7:27 AM

rebase

This revision was landed with ongoing or failed builds.Sep 19 2022, 7:28 AM
Closed by commit rCOMM37af4e6583b9: [services] Backup - Blob Get Client - Cleanup (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM37af4e6583b9: [services] Backup - Blob Get Client - Cleanup.
Harbormaster completed remote builds in B12284: Diff 16846.Sep 19 2022, 7:39 AM

Revision Contents
Changeset List

PathSize
services/
backup/
blob_client/
src/
4 lines
53 lines

Diff 16855

View Options

services/backup/blob_client/src/get_client.rs

Show All 20 Lines
async function preloadImage(uri: string): Promise<{ async function preloadImage(uri: string): Promise<{
steps: $ReadOnlyArray<MediaMissionStep>, steps: $ReadOnlyArray<MediaMissionStep>,
result: ?Image, result: ?Image,
}> { }> {
let image, exceptionMessage; let image, exceptionMessage;
const start = Date.now(); const start = Date.now();
const imageURI = fetchableMediaURI(uri); const imageURI = fetchableMediaURI(uri);
try { try {
image = await new Promise((resolve, reject) => { image = await new Promise<Image>((resolve, reject) => {
const img = new Image(); const img = new Image();
img.src = imageURI; img.src = imageURI;
img.onload = () => { img.onload = () => {
resolve(img); resolve(img);
}; };
img.onerror = e => { img.onerror = e => {
reject(e); reject(e);
}; };
▲ Show 20 Lines • Show All 129 Lines • ▼ Show 20 Lines if (orientation === 2) {
context.transform(0, -1, -1, 0, dimensions.width, dimensions.height); context.transform(0, -1, -1, 0, dimensions.width, dimensions.height);
} else if (orientation === 8) { } else if (orientation === 8) {
context.transform(0, -1, 1, 0, 0, dimensions.height); context.transform(0, -1, 1, 0, 0, dimensions.height);
} else { } else {
context.transform(1, 0, 0, 1, 0, 0); context.transform(1, 0, 0, 1, 0, 0);
} }
context.drawImage(image, 0, 0); context.drawImage(image, 0, 0);
reorientedBlob = await new Promise(resolve => reorientedBlob = await new Promise<Blob>(resolve =>
canvas.toBlob(blobResult => resolve(blobResult)), canvas.toBlob(blobResult => resolve(blobResult)),
); );
} catch (e) { } catch (e) {
reorientExceptionMessage = getMessageForException(e); reorientExceptionMessage = getMessageForException(e);
} }
URL.revokeObjectURL(initialURI); URL.revokeObjectURL(initialURI);
const uri = reorientedBlob && URL.createObjectURL(reorientedBlob); const uri = reorientedBlob && URL.createObjectURL(reorientedBlob);
steps.push({ steps.push({
▲ Show 20 Lines • Show All 91 Lines • Show Last 20 Lines
View Options

services/backup/blob_client/src/put_client.rs

Show All 20 Lines
async function preloadImage(uri: string): Promise<{ async function preloadImage(uri: string): Promise<{
steps: $ReadOnlyArray<MediaMissionStep>, steps: $ReadOnlyArray<MediaMissionStep>,
result: ?Image, result: ?Image,
}> { }> {
let image, exceptionMessage; let image, exceptionMessage;
const start = Date.now(); const start = Date.now();
const imageURI = fetchableMediaURI(uri); const imageURI = fetchableMediaURI(uri);
try { try {
image = await new Promise((resolve, reject) => { image = await new Promise<Image>((resolve, reject) => {
const img = new Image(); const img = new Image();
img.src = imageURI; img.src = imageURI;
img.onload = () => { img.onload = () => {
resolve(img); resolve(img);
}; };
img.onerror = e => { img.onerror = e => {
reject(e); reject(e);
}; };
▲ Show 20 Lines • Show All 129 Lines • ▼ Show 20 Lines if (orientation === 2) {
context.transform(0, -1, -1, 0, dimensions.width, dimensions.height); context.transform(0, -1, -1, 0, dimensions.width, dimensions.height);
} else if (orientation === 8) { } else if (orientation === 8) {
context.transform(0, -1, 1, 0, 0, dimensions.height); context.transform(0, -1, 1, 0, 0, dimensions.height);
} else { } else {
context.transform(1, 0, 0, 1, 0, 0); context.transform(1, 0, 0, 1, 0, 0);
} }
context.drawImage(image, 0, 0); context.drawImage(image, 0, 0);
reorientedBlob = await new Promise(resolve => reorientedBlob = await new Promise<Blob>(resolve =>
canvas.toBlob(blobResult => resolve(blobResult)), canvas.toBlob(blobResult => resolve(blobResult)),
); );
} catch (e) { } catch (e) {
reorientExceptionMessage = getMessageForException(e); reorientExceptionMessage = getMessageForException(e);
} }
URL.revokeObjectURL(initialURI); URL.revokeObjectURL(initialURI);
const uri = reorientedBlob && URL.createObjectURL(reorientedBlob); const uri = reorientedBlob && URL.createObjectURL(reorientedBlob);
steps.push({ steps.push({
▲ Show 20 Lines • Show All 91 Lines • Show Last 20 Lines