[services] Rust Integration - Backup - Rust - Fix backup utils
AbandonedPublic
Actions

Authored by • karol on Sep 9 2022, 7:07 AM.

Details

Reviewers

• jon
tomek
varun
• max

Summary

Depends on D5097

This fixes the incorrect code from D5072. This commit didn't ruin anything but produced redundant code.

Test Plan

Integration tests don't raise warning for the redundant code anymore

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Sep 9 2022, 7:07 AM

Herald added a reviewer: • jon. · View Herald TranscriptSep 9 2022, 7:07 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• karol edited the summary of this revision. (Show Details)Sep 9 2022, 7:09 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, varun, • max.

• karol added a parent revision: D5097: [services] Backup - Blob Get Client - Cleanup.

• karol added a child revision: D5099: [services] Backup - Blob Get Client - Pass rust string instead of const char*.

Harbormaster completed remote builds in B12054: Diff 16554.Sep 9 2022, 7:17 AM

• karol requested review of this revision.Sep 9 2022, 7:17 AM

This fixes the incorrect code from D5072.

Why don't we just amend D5072? seems like D5072 is expanding the work done while looping through the values anyway.

This revision now requires changes to proceed.Sep 9 2022, 10:35 AM

Right 😅

Revision Contents
Changeset List

Path

Size

services/

commtest/

tests/

backup/

backup_utils.rs

4 lines

Diff 16554

View Options

services/commtest/tests/backup/backup_utils.rs

Show All 34 Lines
#import <React/RCTJSIExecutorRuntimeInstaller.h>		#import <React/RCTJSIExecutorRuntimeInstaller.h>
#import <React/RCTLinkingManager.h>		#import <React/RCTLinkingManager.h>
#import <cxxreact/JSExecutor.h>		#import <cxxreact/JSExecutor.h>
#import <jsireact/JSIExecutor.h>		#import <jsireact/JSIExecutor.h>
#import <reacthermes/HermesExecutorFactory.h>		#import <reacthermes/HermesExecutorFactory.h>

#import "CommConstants.h"		#import "CommConstants.h"
#import "CommCoreModule.h"		#import "CommCoreModule.h"
		#import "CommRustModule.h"
#import "CommUtilsModule.h"		#import "CommUtilsModule.h"
#import "GlobalDBSingleton.h"		#import "GlobalDBSingleton.h"
#import "Logger.h"		#import "Logger.h"
#import "MessageOperationsUtilities.h"		#import "MessageOperationsUtilities.h"
#import "TemporaryMessageStorage.h"		#import "TemporaryMessageStorage.h"
#import "ThreadOperations.h"		#import "ThreadOperations.h"
#import "Tools.h"		#import "Tools.h"
#import <cstdio>		#import <cstdio>
▲ Show 20 Lines • Show All 223 Lines • ▼ Show 20 Lines	if (!bridge) {
return;		return;
}		}
__typeof(self) strongSelf = weakSelf;		__typeof(self) strongSelf = weakSelf;
if (strongSelf) {		if (strongSelf) {
std::shared_ptr<comm::CommCoreModule> coreNativeModule =		std::shared_ptr<comm::CommCoreModule> coreNativeModule =
std::make_shared<comm::CommCoreModule>(bridge.jsCallInvoker);		std::make_shared<comm::CommCoreModule>(bridge.jsCallInvoker);
std::shared_ptr<comm::CommUtilsModule> utilsNativeModule =		std::shared_ptr<comm::CommUtilsModule> utilsNativeModule =
std::make_shared<comm::CommUtilsModule>(bridge.jsCallInvoker);		std::make_shared<comm::CommUtilsModule>(bridge.jsCallInvoker);
		std::shared_ptr<comm::CommRustModule> rustNativeModule =
		std::make_shared<comm::CommRustModule>(bridge.jsCallInvoker);
std::shared_ptr<comm::CommConstants> nativeConstants =		std::shared_ptr<comm::CommConstants> nativeConstants =
std::make_shared<comm::CommConstants>();		std::make_shared<comm::CommConstants>();

rt.global().setProperty(		rt.global().setProperty(
rt,		rt,
facebook::jsi::PropNameID::forAscii(rt, "CommCoreModule"),		facebook::jsi::PropNameID::forAscii(rt, "CommCoreModule"),
facebook::jsi::Object::createFromHostObject(rt, coreNativeModule));		facebook::jsi::Object::createFromHostObject(rt, coreNativeModule));
rt.global().setProperty(		rt.global().setProperty(
rt,		rt,
facebook::jsi::PropNameID::forAscii(rt, "CommUtilsModule"),		facebook::jsi::PropNameID::forAscii(rt, "CommUtilsModule"),
facebook::jsi::Object::createFromHostObject(rt, utilsNativeModule));		facebook::jsi::Object::createFromHostObject(rt, utilsNativeModule));
rt.global().setProperty(		rt.global().setProperty(
rt,		rt,
		facebook::jsi::PropNameID::forAscii(rt, "CommRustModule"),
		facebook::jsi::Object::createFromHostObject(rt, rustNativeModule));
		rt.global().setProperty(
		rt,
facebook::jsi::PropNameID::forAscii(rt, "CommConstants"),		facebook::jsi::PropNameID::forAscii(rt, "CommConstants"),
facebook::jsi::Object::createFromHostObject(rt, nativeConstants));		facebook::jsi::Object::createFromHostObject(rt, nativeConstants));
}		}
};		};
const auto installer =		const auto installer =
reanimated::REAJSIExecutorRuntimeInstaller(bridge, commRuntimeInstaller);		reanimated::REAJSIExecutorRuntimeInstaller(bridge, commRuntimeInstaller);

return std::make_unique<HermesExecutorFactory>(		return std::make_unique<HermesExecutorFactory>(
▲ Show 20 Lines • Show All 117 Lines • Show Last 20 Lines

[services] Rust Integration - Backup - Rust - Fix backup utilsAbandonedPublicActions