Depends on D5094
Linear task: https://linear.app/comm/issue/ENG-1734/improve-error-handling-system-in-the-blob-client
Using a new way of error handling in the blocking_read method of the put client.
Differential D5095 Authored by • karol on Sep 9 2022, 11:44 AM.
Tags None Referenced Files
Details Summary Depends on D5094 Linear task: https://linear.app/comm/issue/ENG-1734/improve-error-handling-system-in-the-blob-client Using a new way of error handling in the blocking_read method of the put client. Test Plan cd services/backup/blob_client cargo check after running localstack, blob and backup (in this particular order), this still works: yarn run-performance-tests backup
Diff Detail
Event TimelineHerald added a reviewer: • jon. · View Herald TranscriptSep 9 2022, 11:44 AM2022-09-09 11:44:27 (UTC+0) • karol edited the summary of this revision. (Show Details)Sep 9 2022, 11:54 AM2022-09-09 11:54:49 (UTC+0) • karol added a child revision: D5096: [services] Backup - Blob Get Client - Refactor put initialize. Harbormaster completed remote builds in B12048: Diff 16547.Sep 9 2022, 11:56 AM2022-09-09 11:56:07 (UTC+0) This revision is now accepted and ready to land.Sep 9 2022, 5:49 PM2022-09-09 17:49:06 (UTC+0) Harbormaster completed remote builds in B12159: Diff 16687.Sep 15 2022, 8:37 AM2022-09-15 08:37:41 (UTC+0) This revision was landed with ongoing or failed builds.Sep 19 2022, 2:28 PM2022-09-19 14:28:23 (UTC+0) Closed by commit rCOMMd368b1a6629b: [services] Backup - Blob Get Client - Refactor put read. · Explain Why This revision was automatically updated to reflect the committed changes. Harbormaster completed remote builds in B12282: Diff 16844.Sep 19 2022, 2:39 PM2022-09-19 14:39:46 (UTC+0)
Revision Contents
Diff 16853 |