Page MenuHomePhabricator
Differential D5073

[services] Rust Integration - Backup - c++ - Use uuid instead of current timestamp when generating log id
ClosedPublic
Actions

Authored by • karol on Sep 6 2022, 7:23 AM.
Tags
None
Referenced Files
F3331327: D5073.id16376.diff
Wed, Nov 20, 8:21 PM
Unknown Object (File)
Thu, Nov 14, 2:11 AM
Unknown Object (File)
Sun, Nov 10, 6:57 AM
Unknown Object (File)
Sun, Oct 27, 8:13 PM
Unknown Object (File)
Sun, Oct 27, 8:13 PM
Unknown Object (File)
Sun, Oct 27, 8:13 PM
Unknown Object (File)
Sun, Oct 27, 8:09 PM
Unknown Object (File)
Wed, Oct 23, 10:09 AM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
• jon
tomek
• max
varun
Commits
rCOMMdbfcccb47cf6: [services] Rust Integration - Backup - c++ - Use uuid instead of current…
Summary

Depends on D5072

I used to have duplicated log ids which lead to errors. This was because they could be sent in such a small interval that they'd have the same timestamp in their IDs. Using UUID solved this problem.

Test Plan

services build

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Sep 6 2022, 7:23 AM
Herald added a reviewer: • jon. · View Herald TranscriptSep 6 2022, 7:23 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript
Harbormaster completed remote builds in B11930: Diff 16376.Sep 6 2022, 7:35 AM
• karol requested review of this revision.Sep 6 2022, 7:35 AM
• karol edited the summary of this revision. (Show Details)Sep 6 2022, 7:37 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max, varun.
• karol added a parent revision: D5072: [services] Rust Integration - Backup - Rust - Fix wrong order of logs in the tests.
• karol added a child revision: D5074: [services] Rust Integration - Backup - c++ - Fix wrong order of attachment holders in tests.Sep 6 2022, 7:40 AM
tomek accepted this revision.Sep 9 2022, 5:49 AM

It is an improvement but we should handle collisions gracefully by generating a new id.

This revision is now accepted and ready to land.Sep 9 2022, 5:49 AM
• karol updated this revision to Diff 16795.Sep 19 2022, 12:59 AM
• karol edited the summary of this revision. (Show Details)

rebase

Harbormaster completed remote builds in B12243: Diff 16795.Sep 19 2022, 1:10 AM
Closed by commit rCOMMdbfcccb47cf6: [services] Rust Integration - Backup - c++ - Use uuid instead of current… (authored by • karol). · Explain WhySep 19 2022, 1:11 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMdbfcccb47cf6: [services] Rust Integration - Backup - c++ - Use uuid instead of current….

Revision Contents
Changeset List

PathSize
services/
backup/
src/
Reactors/
server/
3 lines

Diff 16803

View Options

services/backup/src/Reactors/server/SendLogReactor.cpp

Loading...