Differential D5073 Authored by • karol on Sep 6 2022, 2:23 PM.
Details Summary Depends on D5072 I used to have duplicated log ids which lead to errors. This was because they could be sent in such a small interval that they'd have the same timestamp in their IDs. Using UUID solved this problem. Test Plan services build
Diff Detail
Event TimelineHerald added a reviewer: • jon. · View Herald TranscriptSep 6 2022, 2:23 PM2022-09-06 14:23:06 (UTC+0) Harbormaster completed remote builds in B11930: Diff 16376.Sep 6 2022, 2:35 PM2022-09-06 14:35:03 (UTC+0) • karol edited the summary of this revision. (Show Details)Sep 6 2022, 2:37 PM2022-09-06 14:37:53 (UTC+0) • karol added a parent revision: D5072: [services] Rust Integration - Backup - Rust - Fix wrong order of logs in the tests. Comment Actions It is an improvement but we should handle collisions gracefully by generating a new id. This revision is now accepted and ready to land.Sep 9 2022, 12:49 PM2022-09-09 12:49:15 (UTC+0) Harbormaster completed remote builds in B12243: Diff 16795.Sep 19 2022, 8:10 AM2022-09-19 08:10:27 (UTC+0) Closed by commit rCOMMdbfcccb47cf6: [services] Rust Integration - Backup - c++ - Use uuid instead of current…. · Explain WhySep 19 2022, 8:11 AM2022-09-19 08:11:55 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 16376 |