Paths

Table of Contentst

[services] Backup - Blob Get Client - Refactor get read
ClosedPublic
Actions

Authored by • karol on Sep 9 2022, 4:43 AM.

Details

Reviewers

• jon
tomek
• max
varun

Commits

rCOMM14ddb5efea43: [services] Backup - Blob Get Client - Refactor get read

Summary

Depends on D5090

Linear task: https://linear.app/comm/issue/ENG-1734/improve-error-handling-system-in-the-blob-client

Using a new way of error handling in the blocking_read method of the get client.

Test Plan

cd services/backup/blob_client
cargo check

after running localstack, blob and backup (in this particular order), this still works:

yarn run-performance-tests backup

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Sep 9 2022, 4:43 AM

Herald added a reviewer: • jon. · View Herald TranscriptSep 9 2022, 4:43 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B12044: Diff 16543.Sep 9 2022, 4:53 AM

• karol requested review of this revision.Sep 9 2022, 4:53 AM

• karol edited the summary of this revision. (Show Details)Sep 9 2022, 4:54 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max, varun.

• karol added a parent revision: D5090: [services] Backup - Blob Get Client - Refactor get terminate.

• karol added a child revision: D5092: [services] Backup - Blob Get Client - Refactor get initialize.

better

This revision is now accepted and ready to land.Sep 12 2022, 9:42 AM

In D5091#149340, @jon wrote:

better

What do you mean by just saying "better" with no previous context?

In D5091#150005, @karol wrote:

In D5091#149340, @jon wrote:

better

What do you mean by just saying "better" with no previous context?

I think that @jon considers this version as better than the previous one.

services/backup/blob_client/src/get_client.rs
135 ↗	(On Diff #16543)

• karol added inline comments.Sep 19 2022, 7:13 AM

services/backup/blob_client/src/get_client.rs
135 ↗	(On Diff #16543)	https://linear.app/comm/issue/ENG-1841/use-short-version-of-anyhow-result

rebase

This revision was landed with ongoing or failed builds.Sep 19 2022, 7:27 AM

Closed by commit rCOMM14ddb5efea43: [services] Backup - Blob Get Client - Refactor get read (authored by • karol). · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM14ddb5efea43: [services] Backup - Blob Get Client - Refactor get read.

Harbormaster completed remote builds in B12278: Diff 16840.Sep 19 2022, 7:35 AM

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

get_client.rs

22 lines

Diff 16849

View Options

services/backup/blob_client/src/get_client.rs

[services] Backup - Blob Get Client - Refactor get readClosedPublicActions