Depends on D5097
Raised in https://phab.comm.dev/D5035#148669
We can construct rust::Strings in c++ instead of passing const char*s from c++ to rust.
Details
Details
Services build, tests pass.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/backup/blob_client/src/lib.rs | ||
|---|---|---|
| 17–39 ↗ | (On Diff #16556) | Are the functions still unsafe? Our guess was that it was caused by a raw pointer. |
| services/backup/blob_client/src/lib.rs | ||
|---|---|---|
| 17–39 ↗ | (On Diff #16556) | Right, missed that. |
| services/backup/blob_client/src/put_client.rs | ||
|---|---|---|
| 200 ↗ | (On Diff #16576) | since we are just passing this to a hashmap, we should be able to use &str. Also avoids all the .clone() usage everywhere as you're no longer taking ownership of the string |
| services/backup/blob_client/src/put_client.rs | ||
|---|---|---|
| 200 ↗ | (On Diff #16576) | Right, we can refactor some Strings into &strs, will do. |