Paths

Table of Contentst

Differential D5099

[services] Backup - Blob Get Client - Pass rust string instead of const char*
ClosedPublic
Actions

Authored by • karol on Sep 9 2022, 2:07 PM.

Tags

None

Referenced Files

	F32559041: D5099.1767277103.diff
	Wed, Dec 31, 2:18 PM

Subscribers

Details

Reviewers

• jon
tomek
• max
varun

Commits

rCOMMfad989a99d6c: [services] Backup - Blob Get Client - Pass rust string instead of const char*

Summary

Depends on D5097

Raised in https://phab.comm.dev/D5035#148669

We can construct rust::Strings in c++ instead of passing const char*s from c++ to rust.

Test Plan

Services build, tests pass.

Diff Detail

Repository

Branch

@karol/integrate-rust-diffs

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Sep 9 2022, 2:07 PM

Herald added a reviewer: • jon. · View Herald TranscriptSep 9 2022, 2:07 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 9 2022, 2:08 PM

Harbormaster failed remote builds in B12055: Diff 16555!

• karol edited the summary of this revision. (Show Details)Sep 9 2022, 2:11 PM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max, varun.

• karol added a parent revision: D5098: [services] Rust Integration - Backup - Rust - Fix backup utils.

• karol mentioned this in D5035: [services] Rust Integration - Backup - Rust - Multiple put clients.

retrigger CI - failed on identity build that's unrelated

Harbormaster completed remote builds in B12056: Diff 16556.Sep 9 2022, 2:22 PM

• karol requested review of this revision.Sep 9 2022, 2:22 PM

tomek requested changes to this revision.Sep 9 2022, 2:30 PM

tomek added inline comments.

services/backup/blob_client/src/lib.rs
17–39 ↗	(On Diff #16556)	Are the functions still unsafe? Our guess was that it was caused by a raw pointer.

This revision now requires changes to proceed.Sep 9 2022, 2:30 PM

• karol added inline comments.Sep 9 2022, 2:41 PM

services/backup/blob_client/src/lib.rs
17–39 ↗	(On Diff #16556)	Right, missed that.

avoid unsafe

Harbormaster completed remote builds in B12076: Diff 16576.Sep 12 2022, 8:49 AM

• jon requested changes to this revision.Sep 12 2022, 4:11 PM

• jon added inline comments.

services/backup/blob_client/src/put_client.rs
200	since we are just passing this to a hashmap, we should be able to use `&str`. Also avoids all the `.clone()` usage everywhere as you're no longer taking ownership of the string

This revision now requires changes to proceed.Sep 12 2022, 4:11 PM

• karol edited the summary of this revision. (Show Details)Sep 13 2022, 8:09 AM

• karol added a parent revision: D5097: [services] Backup - Blob Get Client - Cleanup.

• karol added inline comments.Sep 13 2022, 8:31 AM

services/backup/blob_client/src/put_client.rs
200	Right, we can refactor some `String`s into `&str`s, will do.

use more &str instead of String

Harbormaster completed remote builds in B12110: Diff 16617.Sep 13 2022, 8:41 AM

improvement

tomek accepted this revision.Sep 15 2022, 4:02 PM

This revision is now accepted and ready to land.Sep 15 2022, 4:02 PM

• karol mentioned this in D5089: [services] Backup - Blob Get Client - Prepare for error handling.Sep 15 2022, 4:09 PM

remove tools

Harbormaster completed remote builds in B12182: Diff 16710.Sep 15 2022, 4:27 PM

rebase

This revision was landed with ongoing or failed builds.Sep 19 2022, 2:28 PM

Closed by commit rCOMMfad989a99d6c: [services] Backup - Blob Get Client - Pass rust string instead of const char*. · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMfad989a99d6c: [services] Backup - Blob Get Client - Pass rust string instead of const char*.

Harbormaster completed remote builds in B12285: Diff 16847.Sep 19 2022, 2:45 PM

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

14 lines

27 lines

15 lines

src/

Reactors/

server/

AddAttachmentsUtility.cpp

19 lines

CreateNewBackupReactor.cpp

16 lines

PullBackupReactor.cpp

2 lines

SendLogReactor.cpp

12 lines

Diff 16576

services/backup/blob_client/src/get_client.rs

Loading...

services/backup/blob_client/src/lib.rs

Loading...

services/backup/blob_client/src/put_client.rs

Loading...

services/backup/src/Reactors/server/AddAttachmentsUtility.cpp

Loading...

services/backup/src/Reactors/server/CreateNewBackupReactor.cpp

Loading...

services/backup/src/Reactors/server/PullBackupReactor.cpp

Loading...

services/backup/src/Reactors/server/SendLogReactor.cpp

Loading...