Paths

Table of Contentst

[services] Backup - Blob Get Client - Refactor get initialize
ClosedPublic
Actions

Authored by • karol on Sep 9 2022, 4:43 AM.

Details

Reviewers

• jon
• max
varun
tomek

Commits

rCOMM448ee799463f: [services] Backup - Blob Get Client - Refactor get initialize

Summary

Depends on D5091

Linear task: https://linear.app/comm/issue/ENG-1734/improve-error-handling-system-in-the-blob-client

Using a new way of error handling in the initialize method of the get client.

Test Plan

cd services/backup/blob_client
cargo check

after running localstack, blob and backup (in this particular order), this still works:

yarn run-performance-tests backup

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Sep 9 2022, 4:43 AM

Herald added a reviewer: • jon. · View Herald TranscriptSep 9 2022, 4:43 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B12045: Diff 16544.Sep 9 2022, 4:53 AM

• karol requested review of this revision.Sep 9 2022, 4:53 AM

• karol edited the summary of this revision. (Show Details)Sep 9 2022, 4:54 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: • max, varun, tomek.

• karol added a parent revision: D5091: [services] Backup - Blob Get Client - Refactor get read.

• karol added a child revision: D5093: [services] Backup - Blob Get Client - Refactor put terminate.

• karol planned changes to this revision.Sep 12 2022, 1:35 AM

update

Harbormaster completed remote builds in B12073: Diff 16573.Sep 12 2022, 1:47 AM

better

This revision is now accepted and ready to land.Sep 12 2022, 9:42 AM

In D5092#149343, @jon wrote:

better

What do you mean by just saying "better" with no previous context?

Please update the Result type

services/backup/blob_client/src/get_client.rs
52–54 ↗	(On Diff #16573)	You can use `ensure`

tomek mentioned this in D5093: [services] Backup - Blob Get Client - Refactor put terminate.Sep 15 2022, 8:46 AM

• karol mentioned this in D5037: [services] Rust Integration - Backup - Rust - Multiple get clients.Sep 16 2022, 1:45 AM

In D5092#150546, @tomek wrote:

Please update the Result type

https://linear.app/comm/issue/ENG-1841/use-short-version-of-anyhow-result

services/backup/blob_client/src/get_client.rs
52–54 ↗	(On Diff #16573)	https://linear.app/comm/issue/ENG-1840/use-ensure-instead-of-bail

rebase

This revision was landed with ongoing or failed builds.Sep 19 2022, 7:28 AM

Closed by commit rCOMM448ee799463f: [services] Backup - Blob Get Client - Refactor get initialize (authored by • karol). · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM448ee799463f: [services] Backup - Blob Get Client - Refactor get initialize.

Harbormaster completed remote builds in B12279: Diff 16841.Sep 19 2022, 7:36 AM

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

get_client.rs

87 lines

Diff 16850

View Options

services/backup/blob_client/src/get_client.rs

[services] Backup - Blob Get Client - Refactor get initializeClosedPublicActions