Page MenuHomePhabricator
Differential D5071

[services] Rust Integration - c++ - Implement worker in write reactor
ClosedPublic
Actions

Authored by • karol on Sep 6 2022, 7:22 AM.
Tags
None
Referenced Files
F1746520: D5071.id16801.diff
Mon, May 13, 2:57 PM
F1746519: D5071.id16793.diff
Mon, May 13, 2:57 PM
F1746518: D5071.id.diff
Mon, May 13, 2:56 PM
Unknown Object (File)
Thu, May 9, 5:21 PM
Unknown Object (File)
Tue, May 7, 3:05 AM
Unknown Object (File)
Fri, May 3, 8:20 PM
Unknown Object (File)
Thu, May 2, 3:50 PM
Unknown Object (File)
Thu, May 2, 11:13 AM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
tomek
• max
• jon
Commits
rCOMM82f40e12ac63: [services] Rust Integration - c++ - Implement worker in write reactor
Summary

Depends on D5070

In response to this issue, we should implement the code that will delegate the work away from the reactors to separate threads.

Here, I implement using the worker in the write reactors.

Test Plan

Services build as usual.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Sep 6 2022, 7:22 AM
Herald added a reviewer: • jon. · View Herald TranscriptSep 6 2022, 7:22 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript
• karol edited the summary of this revision. (Show Details)Sep 6 2022, 7:28 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max.
• karol added a parent revision: D5070: [services] Rust Integration - c++ - Implement worker in read reactor.
Harbormaster completed remote builds in B11928: Diff 16374.Sep 6 2022, 7:32 AM
• karol requested review of this revision.Sep 6 2022, 7:32 AM
• karol added a child revision: D5072: [services] Rust Integration - Backup - Rust - Fix wrong order of logs in the tests.Sep 6 2022, 7:35 AM
• karol planned changes to this revision.Sep 7 2022, 2:00 AM
• karol updated this revision to Diff 16395.Sep 7 2022, 2:18 AM

rebase

Harbormaster completed remote builds in B11944: Diff 16395.Sep 7 2022, 2:27 AM
tomek requested changes to this revision.Sep 9 2022, 5:33 AM

The same as in D5069

This revision now requires changes to proceed.Sep 9 2022, 5:33 AM
• karol requested review of this revision.Sep 13 2022, 1:01 AM
• karol planned changes to this revision.Sep 14 2022, 2:59 AM
• karol updated this revision to Diff 16657.Sep 14 2022, 3:00 AM

rebase

Harbormaster completed remote builds in B12135: Diff 16657.Sep 14 2022, 3:10 AM
• jon resigned from this revision.Sep 14 2022, 10:50 AM
tomek accepted this revision.Sep 15 2022, 7:59 AM

Assuming that this type of capture is correct (see D5070 where this will be clarified)

This revision is now accepted and ready to land.Sep 15 2022, 7:59 AM
• karol updated this revision to Diff 16706.Sep 15 2022, 9:00 AM

rebase

Harbormaster completed remote builds in B12178: Diff 16706.Sep 15 2022, 9:11 AM
• karol updated this revision to Diff 16793.Sep 19 2022, 12:58 AM

rebase

Harbormaster completed remote builds in B12241: Diff 16793.Sep 19 2022, 1:08 AM
Closed by commit rCOMM82f40e12ac63: [services] Rust Integration - c++ - Implement worker in write reactor (authored by • karol). · Explain WhySep 19 2022, 1:11 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM82f40e12ac63: [services] Rust Integration - c++ - Implement worker in write reactor.

Revision Contents
Changeset List

PathSize
services/
lib/
src/
server-base-reactors/
77 lines

Diff 16801

View Options

services/lib/src/server-base-reactors/ServerWriteReactorBase.h

Loading...