Page MenuHomePhabricator
Differential D5112

[services] Rust Integration - c++ - Add getNumberOfCores
ClosedPublic
Actions

Authored by • karol on Sep 12 2022, 7:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 18, 8:50 PM
Unknown Object (File)
Tue, Mar 18, 8:50 PM
Unknown Object (File)
Tue, Mar 18, 8:50 PM
Unknown Object (File)
Tue, Mar 18, 12:43 PM
Unknown Object (File)
Mon, Mar 17, 4:10 AM
Unknown Object (File)
Mon, Mar 17, 4:10 AM
Unknown Object (File)
Mon, Mar 17, 4:10 AM
Unknown Object (File)
Mon, Mar 17, 4:10 AM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
• jon
tomek
• max
varun
Commits
rCOMM4486a9c39522: [services] Rust Integration - c++ - Add getNumberOfCores
Summary

Depends on D5038

We need a thread pool to address the grpc's threading problem in c++. To decide what can be a limit for the threads in the thread pool, we should probably obtain a number of CPUs on the machine.

Test Plan

services build as usual

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Sep 12 2022, 7:10 AM
Herald added a reviewer: • jon. · View Herald TranscriptSep 12 2022, 7:10 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript
• karol added a child revision: D5068: [services] Rust Integration - c++ - Add worker.Sep 12 2022, 7:11 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max, varun.
• karol added a parent revision: D5038: [services] Rust Integration - Backup - c++ - Multiple get clients.
Harbormaster completed remote builds in B12082: Diff 16583.Sep 12 2022, 7:20 AM
• karol requested review of this revision.Sep 12 2022, 7:20 AM
• jon accepted this revision.Sep 12 2022, 9:09 AM
This revision is now accepted and ready to land.Sep 12 2022, 9:09 AM
tomek requested changes to this revision.Sep 13 2022, 11:01 AM
tomek added inline comments.
services/lib/src/GlobalTools.cpp
32 ↗(On Diff #16583)

This name is confusing: for the majority of devices the number of CPUs is simply 1. What you probably wanted to express here is the number of cores. I guess that due to features like multi-threading, the number of cores doesn't necessarily equals number of hardware threads, but still that name is a lot less misleading.

Returns the number of concurrent threads supported by the implementation.

33 ↗(On Diff #16583)

The docs https://en.cppreference.com/w/cpp/thread/thread/hardware_concurrency specify that the return value is

Number of concurrent threads supported. If the value is not well defined or not computable, returns ​0​.

But we're not handling the 0 in any way.

This revision now requires changes to proceed.Sep 13 2022, 11:01 AM
• karol updated this revision to Diff 16653.Sep 14 2022, 1:44 AM

Thanks for the review. Addressed feedback.

Harbormaster completed remote builds in B12131: Diff 16653.Sep 14 2022, 1:54 AM
tomek accepted this revision.Sep 15 2022, 7:30 AM
tomek added inline comments.
services/lib/src/GlobalTools.cpp
34 ↗(On Diff #16653)

Have you checked if u suffix works?

This revision is now accepted and ready to land.Sep 15 2022, 7:30 AM
• karol retitled this revision from [services] Rust Integration - c++ - Add getNumberOfCpus to [services] Rust Integration - c++ - Add getNumberOfCores.Sep 16 2022, 1:47 AM
• karol added inline comments.Sep 16 2022, 1:49 AM
services/lib/src/GlobalTools.cpp
34 ↗(On Diff #16653)

it works, thx

• karol updated this revision to Diff 16734.Sep 16 2022, 1:49 AM

1u

• karol updated this revision to Diff 16740.Sep 16 2022, 1:54 AM

rebase

This revision was landed with ongoing or failed builds.Sep 16 2022, 1:55 AM
Closed by commit rCOMM4486a9c39522: [services] Rust Integration - c++ - Add getNumberOfCores (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM4486a9c39522: [services] Rust Integration - c++ - Add getNumberOfCores.
Harbormaster completed remote builds in B12199: Diff 16734.Sep 16 2022, 2:00 AM
Harbormaster completed remote builds in B12205: Diff 16740.Sep 16 2022, 2:11 AM

Revision Contents
Changeset List

PathSize
services/
lib/
src/
2 lines
6 lines

Diff 16746

View Options

services/lib/src/GlobalTools.h

Show All 34 Lines
#import <React/RCTJSIExecutorRuntimeInstaller.h> #import <React/RCTJSIExecutorRuntimeInstaller.h>
#import <React/RCTLinkingManager.h> #import <React/RCTLinkingManager.h>
#import <cxxreact/JSExecutor.h> #import <cxxreact/JSExecutor.h>
#import <jsireact/JSIExecutor.h> #import <jsireact/JSIExecutor.h>
#import <reacthermes/HermesExecutorFactory.h> #import <reacthermes/HermesExecutorFactory.h>
#import "CommConstants.h" #import "CommConstants.h"
#import "CommCoreModule.h" #import "CommCoreModule.h"
#import "CommRustModule.h"
#import "CommUtilsModule.h" #import "CommUtilsModule.h"
#import "GlobalDBSingleton.h" #import "GlobalDBSingleton.h"
#import "Logger.h" #import "Logger.h"
#import "MessageOperationsUtilities.h" #import "MessageOperationsUtilities.h"
#import "TemporaryMessageStorage.h" #import "TemporaryMessageStorage.h"
#import "ThreadOperations.h" #import "ThreadOperations.h"
#import "Tools.h" #import "Tools.h"
#import <cstdio> #import <cstdio>
▲ Show 20 Lines • Show All 223 Lines • ▼ Show 20 Lines if (!bridge) {
return; return;
} }
__typeof(self) strongSelf = weakSelf; __typeof(self) strongSelf = weakSelf;
if (strongSelf) { if (strongSelf) {
std::shared_ptr<comm::CommCoreModule> coreNativeModule = std::shared_ptr<comm::CommCoreModule> coreNativeModule =
std::make_shared<comm::CommCoreModule>(bridge.jsCallInvoker); std::make_shared<comm::CommCoreModule>(bridge.jsCallInvoker);
std::shared_ptr<comm::CommUtilsModule> utilsNativeModule = std::shared_ptr<comm::CommUtilsModule> utilsNativeModule =
std::make_shared<comm::CommUtilsModule>(bridge.jsCallInvoker); std::make_shared<comm::CommUtilsModule>(bridge.jsCallInvoker);
std::shared_ptr<comm::CommRustModule> rustNativeModule =
std::make_shared<comm::CommRustModule>(bridge.jsCallInvoker);
std::shared_ptr<comm::CommConstants> nativeConstants = std::shared_ptr<comm::CommConstants> nativeConstants =
std::make_shared<comm::CommConstants>(); std::make_shared<comm::CommConstants>();
rt.global().setProperty( rt.global().setProperty(
rt, rt,
facebook::jsi::PropNameID::forAscii(rt, "CommCoreModule"), facebook::jsi::PropNameID::forAscii(rt, "CommCoreModule"),
facebook::jsi::Object::createFromHostObject(rt, coreNativeModule)); facebook::jsi::Object::createFromHostObject(rt, coreNativeModule));
rt.global().setProperty( rt.global().setProperty(
rt, rt,
facebook::jsi::PropNameID::forAscii(rt, "CommUtilsModule"), facebook::jsi::PropNameID::forAscii(rt, "CommUtilsModule"),
facebook::jsi::Object::createFromHostObject(rt, utilsNativeModule)); facebook::jsi::Object::createFromHostObject(rt, utilsNativeModule));
rt.global().setProperty( rt.global().setProperty(
rt, rt,
facebook::jsi::PropNameID::forAscii(rt, "CommRustModule"),
facebook::jsi::Object::createFromHostObject(rt, rustNativeModule));
rt.global().setProperty(
rt,
facebook::jsi::PropNameID::forAscii(rt, "CommConstants"), facebook::jsi::PropNameID::forAscii(rt, "CommConstants"),
facebook::jsi::Object::createFromHostObject(rt, nativeConstants)); facebook::jsi::Object::createFromHostObject(rt, nativeConstants));
} }
}; };
const auto installer = const auto installer =
reanimated::REAJSIExecutorRuntimeInstaller(bridge, commRuntimeInstaller); reanimated::REAJSIExecutorRuntimeInstaller(bridge, commRuntimeInstaller);
return std::make_unique<HermesExecutorFactory>( return std::make_unique<HermesExecutorFactory>(
▲ Show 20 Lines • Show All 117 Lines • Show Last 20 Lines
View Options

services/lib/src/GlobalTools.cpp

Show All 34 Lines
#import <React/RCTJSIExecutorRuntimeInstaller.h> #import <React/RCTJSIExecutorRuntimeInstaller.h>
#import <React/RCTLinkingManager.h> #import <React/RCTLinkingManager.h>
#import <cxxreact/JSExecutor.h> #import <cxxreact/JSExecutor.h>
#import <jsireact/JSIExecutor.h> #import <jsireact/JSIExecutor.h>
#import <reacthermes/HermesExecutorFactory.h> #import <reacthermes/HermesExecutorFactory.h>
#import "CommConstants.h" #import "CommConstants.h"
#import "CommCoreModule.h" #import "CommCoreModule.h"
#import "CommRustModule.h"
#import "CommUtilsModule.h" #import "CommUtilsModule.h"
#import "GlobalDBSingleton.h" #import "GlobalDBSingleton.h"
#import "Logger.h" #import "Logger.h"
#import "MessageOperationsUtilities.h" #import "MessageOperationsUtilities.h"
#import "TemporaryMessageStorage.h" #import "TemporaryMessageStorage.h"
#import "ThreadOperations.h" #import "ThreadOperations.h"
#import "Tools.h" #import "Tools.h"
#import <cstdio> #import <cstdio>
▲ Show 20 Lines • Show All 223 Lines • ▼ Show 20 Lines if (!bridge) {
return; return;
} }
__typeof(self) strongSelf = weakSelf; __typeof(self) strongSelf = weakSelf;
if (strongSelf) { if (strongSelf) {
std::shared_ptr<comm::CommCoreModule> coreNativeModule = std::shared_ptr<comm::CommCoreModule> coreNativeModule =
std::make_shared<comm::CommCoreModule>(bridge.jsCallInvoker); std::make_shared<comm::CommCoreModule>(bridge.jsCallInvoker);
std::shared_ptr<comm::CommUtilsModule> utilsNativeModule = std::shared_ptr<comm::CommUtilsModule> utilsNativeModule =
std::make_shared<comm::CommUtilsModule>(bridge.jsCallInvoker); std::make_shared<comm::CommUtilsModule>(bridge.jsCallInvoker);
std::shared_ptr<comm::CommRustModule> rustNativeModule =
std::make_shared<comm::CommRustModule>(bridge.jsCallInvoker);
std::shared_ptr<comm::CommConstants> nativeConstants = std::shared_ptr<comm::CommConstants> nativeConstants =
std::make_shared<comm::CommConstants>(); std::make_shared<comm::CommConstants>();
rt.global().setProperty( rt.global().setProperty(
rt, rt,
facebook::jsi::PropNameID::forAscii(rt, "CommCoreModule"), facebook::jsi::PropNameID::forAscii(rt, "CommCoreModule"),
facebook::jsi::Object::createFromHostObject(rt, coreNativeModule)); facebook::jsi::Object::createFromHostObject(rt, coreNativeModule));
rt.global().setProperty( rt.global().setProperty(
rt, rt,
facebook::jsi::PropNameID::forAscii(rt, "CommUtilsModule"), facebook::jsi::PropNameID::forAscii(rt, "CommUtilsModule"),
facebook::jsi::Object::createFromHostObject(rt, utilsNativeModule)); facebook::jsi::Object::createFromHostObject(rt, utilsNativeModule));
rt.global().setProperty( rt.global().setProperty(
rt, rt,
facebook::jsi::PropNameID::forAscii(rt, "CommRustModule"),
facebook::jsi::Object::createFromHostObject(rt, rustNativeModule));
rt.global().setProperty(
rt,
facebook::jsi::PropNameID::forAscii(rt, "CommConstants"), facebook::jsi::PropNameID::forAscii(rt, "CommConstants"),
facebook::jsi::Object::createFromHostObject(rt, nativeConstants)); facebook::jsi::Object::createFromHostObject(rt, nativeConstants));
} }
}; };
const auto installer = const auto installer =
reanimated::REAJSIExecutorRuntimeInstaller(bridge, commRuntimeInstaller); reanimated::REAJSIExecutorRuntimeInstaller(bridge, commRuntimeInstaller);
return std::make_unique<HermesExecutorFactory>( return std::make_unique<HermesExecutorFactory>(
▲ Show 20 Lines • Show All 117 Lines • Show Last 20 Lines