Paths

Table of Contentst

[services] Backup - Blob Get Client - Refactor put read
ClosedPublic
Actions

Authored by • karol on Sep 9 2022, 4:44 AM.

Details

Reviewers

• jon
• max
varun
tomek

Commits

rCOMMd368b1a6629b: [services] Backup - Blob Get Client - Refactor put read

Summary

Depends on D5094

Linear task: https://linear.app/comm/issue/ENG-1734/improve-error-handling-system-in-the-blob-client

Using a new way of error handling in the blocking_read method of the put client.

Test Plan

cd services/backup/blob_client
cargo check

after running localstack, blob and backup (in this particular order), this still works:

yarn run-performance-tests backup

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Sep 9 2022, 4:44 AM

Herald added a reviewer: • jon. · View Herald TranscriptSep 9 2022, 4:44 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• karol edited the summary of this revision. (Show Details)Sep 9 2022, 4:54 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: • max, varun, tomek.

• karol added a parent revision: D5094: [services] Backup - Blob Get Client - Refactor put write.

• karol added a child revision: D5096: [services] Backup - Blob Get Client - Refactor put initialize.

Harbormaster completed remote builds in B12048: Diff 16547.Sep 9 2022, 4:56 AM

• karol requested review of this revision.Sep 9 2022, 4:56 AM

• jon accepted this revision.Sep 9 2022, 10:49 AM

This revision is now accepted and ready to land.Sep 9 2022, 10:49 AM

rebase

Harbormaster completed remote builds in B12159: Diff 16687.Sep 15 2022, 1:37 AM

tomek accepted this revision.Sep 15 2022, 8:51 AM

tomek added inline comments.

services/backup/blob_client/src/put_client.rs
201

rebase

This revision was landed with ongoing or failed builds.Sep 19 2022, 7:28 AM

Closed by commit rCOMMd368b1a6629b: [services] Backup - Blob Get Client - Refactor put read (authored by • karol). · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMd368b1a6629b: [services] Backup - Blob Get Client - Refactor put read.

Harbormaster completed remote builds in B12282: Diff 16844.Sep 19 2022, 7:39 AM

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

put_client.rs

31 lines

tools.rs

22 lines

Diff 16687

View Options

services/backup/blob_client/src/put_client.rs