Details

Reviewers

• jon
• max
varun
tomek

Commits

rCOMM37af4e6583b9: [services] Backup - Blob Get Client - Cleanup

Summary

Depends on D5096

Linear task: https://linear.app/comm/issue/ENG-1734/improve-error-handling-system-in-the-blob-client

Removing ERROR_MESSAGES in both client.

For the put client, deferring handling an error to only one place in the code.

Test Plan

cd services/backup/blob_client
cargo check

after running localstack, blob, and backup (in this particular order), this still works:

yarn run-integration-tests backup
yarn run-performance-tests backup

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Sep 9 2022, 11:44 AM

Herald added a reviewer: • jon. · View Herald TranscriptSep 9 2022, 11:45 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• karol edited the summary of this revision. (Show Details)Sep 9 2022, 11:55 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: • max, varun, tomek.

• karol added a parent revision: D5096: [services] Backup - Blob Get Client - Refactor put initialize.

• karol edited the test plan for this revision. (Show Details)Sep 9 2022, 11:58 AM

Harbormaster completed remote builds in B12050: Diff 16549.Sep 9 2022, 11:59 AM

• karol requested review of this revision.Sep 9 2022, 11:59 AM

• karol added a child revision: D5098: [services] Rust Integration - Backup - Rust - Fix backup utils.Sep 9 2022, 2:09 PM

better than panic'ing

This revision is now accepted and ready to land.Sep 9 2022, 5:38 PM

• karol mentioned this in D5096: [services] Backup - Blob Get Client - Refactor put initialize.Sep 12 2022, 8:07 AM

update

Harbormaster completed remote builds in B12071: Diff 16571.Sep 12 2022, 8:27 AM

• karol added a child revision: D5099: [services] Backup - Blob Get Client - Pass rust string instead of const char*.Sep 13 2022, 8:09 AM

rebase

Harbormaster completed remote builds in B12161: Diff 16689.Sep 15 2022, 8:40 AM

tomek accepted this revision.Sep 15 2022, 4:00 PM

tomek added inline comments.

services/backup/blob_client/src/put_client.rs
185–188 ↗	(On Diff #16689)	The formatting should be done earlier in the stack

rebase

This revision was landed with ongoing or failed builds.Sep 19 2022, 2:28 PM

Closed by commit rCOMM37af4e6583b9: [services] Backup - Blob Get Client - Cleanup. · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM37af4e6583b9: [services] Backup - Blob Get Client - Cleanup.

Harbormaster completed remote builds in B12284: Diff 16846.Sep 19 2022, 2:39 PM

[services] Backup - Blob Get Client - Cleanup
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 16846

services/backup/blob_client/src/get_client.rs

services/backup/blob_client/src/put_client.rs

[services] Backup - Blob Get Client - CleanupClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16846

services/backup/blob_client/src/get_client.rs

services/backup/blob_client/src/put_client.rs

[services] Backup - Blob Get Client - Cleanup
ClosedPublic
Actions

Revision Contents
Changeset List