Depends on D5017
Adding c++ implementation for using the blob client in the backup reactor for adding attachments.
Details
Details
backup builds
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/backup/src/Reactors/server/AddAttachmentsUtility.cpp | ||
|---|---|---|
| 78–80 ↗ | (On Diff #16246) | Doesn't seem like parentheses pair here.
Are you sure? |
Comment Actions
fix
| services/backup/src/Reactors/server/AddAttachmentsUtility.cpp | ||
|---|---|---|
| 78–80 ↗ | (On Diff #16246) | ok thx not sure how this happened, will fix |
| services/backup/src/Reactors/server/AddAttachmentsUtility.cpp | ||
|---|---|---|
| 81 | Is there a downside of calling one write after another without the read between them? | |
| services/backup/src/Reactors/server/AddAttachmentsUtility.cpp | ||
|---|---|---|
| 81 | I think I explained this in another task. Anyway, the thing is, this is how grpc works, it yields a response even if it is empty. Our response queue is limited to 1 (after that, it will hang), so we should always read using the bidi stream, no matter if we use the response or not. We can, of course, add additional logic that would automatically discard responses. | |