HomePhabricator
Diffusion Comm 9dd68c7c57e0

[web] cleanup password change modal

Description

[web] cleanup password change modal

Summary:
This diff cleans up the one off styles in the password change modal and replaces it with styles of the redesigned modal.

As part of cleanup for this modal there were some creative liberties I took which I will outline below:

  • The old password change modal would display their error message to the left of the main CTA button

Screenshot 2023-12-05 at 5.56.43 PM.png (1×3 px, 766 KB)

  • However based on the new redesigned modals: "If there is only one button for the modal, then the button will fill up the entire space of the section"
  • I moved the error message to be below the last input of the modal
  • I also added a placeholder spacing (to match the height of the error message) below the last input so that if an error message is shown then the height of the modal will not change

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D10230

Test Plan:
Please see screenshot below

default case:

Screenshot 2023-12-07 at 2.38.10 PM.png (1×3 px, 795 KB)

error case:

Screenshot 2023-12-07 at 2.38.17 PM.png (1×3 px, 779 KB)

Reviewers: atul, rohan, kamil

Reviewed By: rohan

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D10232

Details

Provenance
ginsuAuthored on Dec 6 2023, 8:54 PM
Reviewer
rohan
Differential Revision
D10232: [web] cleanup password change modal
Parents
rCOMM29e38b3829a3: [web] cleanup community roles modal
Branches
Unknown
Tags
Unknown