HomePhabricator
Diffusion Comm 9f1b2e8c7802

[Flow202][native][skip-ci] [39/x] Fix type error in…

Description

[Flow202][native][skip-ci] [39/x] Fix type error in ensureAndroidPushNotifsEnabled

Summary:
Flow identified a legitimate type error here. When we find we don't have Android notif permissions, we ignore the result of requestAndroidNotificationsPermission. It seems like that would cause us to fail to register notif permissions on Android.

@marcin, can you confirm this interpretation?

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10022

Test Plan: Confirm the Flow errors go away

Reviewers: marcin, michal, tomek

Reviewed By: marcin

Subscribers: marcin

Differential Revision: https://phab.comm.dev/D10023