HomePhabricator
Diffusion Comm a0fe061a40fe

[native] Refactor out EnumSettingsOption into its own component

Description

[native] Refactor out EnumSettingsOption into its own component

Summary:
A EnumSettingsOption counterpart is used on native during community creation, however it's built into the community configuration screen directly since we don't use it anywhere else on native. I'm going to need something similar for selecting role permissions, so I just made a pretty clean refactor into its own component. I recall there was some talk about needing to confirm the actual designs for checked / unchecked, but for now I've just copied it straight over without any design changes.

The reason icon is an optional prop is because at the moment, the designs for role permissions don't require an icon so it made more sense to just make it optional entirely.

Test Plan:
Ran through the community creation flow and logged into another user to confirm that the 'announcement root' setting actually applied (video below). Also I'll show what it looks like if an icon is not provided.

Simulator Screen Shot - iPhone 14 Pro - 2023-06-22 at 14.36.17.png (2×1 px, 145 KB)

Reviewers: atul

Reviewed By: atul

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D8295

Details

Provenance
rohanAuthored on Jun 22 2023, 11:31 AM
Reviewer
atul
Differential Revision
D8295: [native] Refactor out EnumSettingsOption into its own component
Parents
rCOMMe1a40d1ec5df: Bump aws-sigv4 from 0.54.1 to 0.54.2 in /services/blob
Branches
Unknown
Tags
Unknown