HomePhabricator
Diffusion Comm a3c72b23eade

[native] Update to react-native-async-storage@1.17.10

Description

[native] Update to react-native-async-storage@1.17.10

Summary: As part of ENG-614, I ran npx @rnx-kit/dep-check --set-version 0.69.6 on the advice of React Native Upgrade Helper. That script directed me to update react-native-async-storage.

Test Plan:

  1. I ran the app on my iOS Simulator and confirmed things generally still are persisted
  2. I ran through the release notes. I found two things that might potentially be of note:
    • Version 1.16.0 migrated from Flow to Typescript. The new version doesn't appear to introduce type errors despite our code directly called methods on AsyncStorage, so I investigated a bit more. Turns out that we don't have types for AsyncStorage on master today, based on flow type-at-pos inspection. It's not clear to me why Flow doesn't give any errors... it usually doesn't like modules being untyped when there's no stub in our flow-typed folder or anything mentioned in our .flowconfig. That said, concluded it wasn't worth investigating further given this isn't a regression.
    • Version 1.17.0 deprecated JDK 8 support and now requires JDK 11 or higher. Our dev environment instructions prompt the user to install JDK 11, and our native/android/app/build.gradle doesn't lock to a specific JDK version (as opposed to eg. Expo's). However, the Nix environment seems to use JDK 8. I created ENG-2164 to track.

Reviewers: atul, tomek, bartek

Reviewed By: atul

Subscribers: jon, abosh

Differential Revision: https://phab.comm.dev/D5522

Details

Provenance
ashoatAuthored on Nov 2 2022, 11:42 AM
Reviewer
atul
Differential Revision
D5522: [native] Update to react-native-async-storage@1.17.10
Parents
rCOMMfc0d37a56c5b: added no-var rule to root level eslint
Branches
Unknown
Tags
Unknown