HomePhabricator
Diffusion Comm a59a2f0b08d3

[web] introduce previouslySelectedUsers map to add users list

Description

[web] introduce previouslySelectedUsers map to add users list

Summary:
PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

This diff introduces the previouslySelectedUsers state. Based on the design requirements in the figma we only want to move users in and out of the previously section whenever the modal view changes into "search mode" (whenever searchModeActive changes).

We should not jump the members on their own, they will only be moved when the modal “changes” views when a user searches and then clears.

Screenshot 2024-01-25 at 2.51.14 PM.png (1×2 px, 441 KB)

Screenshot 2024-01-25 at 3.10.39 PM.png (1×1 px, 425 KB)

Subsequent diffs will handle introducing the previously selected users to the UI.

Linear task: https://linear.app/comm/issue/ENG-5960/selected-users-section

Depends on D10819

Test Plan:
Please see the demo video below

Reviewers: atul, inka

Reviewed By: atul

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D10820

Details

Provenance
ginsuAuthored on Jan 25 2024, 11:13 AM
Reviewer
atul
Differential Revision
D10820: [web] introduce previouslySelectedUsers map to add users list
Parents
rCOMM83363ea1dcea: [web] convert pendingUsersToAdd into a map
Branches
Unknown
Tags
Unknown