HomePhabricator
Diffusion Comm a9c364854643

Make App Groups SQLite path a default one. Implement migration from previous…

Description

Make App Groups SQLite path a default one. Implement migration from previous path

Summary: This diff changes implementation of getSQliteFilePath method to return new sqlite path defined by App Groups. Previous version of the method is also kept under different name. It also implements migrationfrom old to new path. Migration uses std::rename instead of NSFileManager API since, std::rename documentation explicitly states that file content shall not be altered in the case of failure. NSFileManager probably works similar but I could not find confirmation in its documentation.

Test Plan: Unistall Comm, build app with new code and install it again. Record new path defined by App Groups. Unistall comm, build with previous version of getSQliteFilePath. Check that the path looks like previous versions. Finally build the new code again, install it, check that database is again under app groups path and the app works correctly which means migration was succesfull.

Reviewers: palys-swm, karol-bisztyga, ashoat

Reviewed By: palys-swm, karol-bisztyga, ashoat

Subscribers: ashoat, Adrian, atul, yayabosh

Differential Revision: https://phabricator.ashoat.com/D3993

Details

Provenance
marcinAuthored on May 10 2022, 4:44 AM
Reviewer
tomek
Differential Revision
D3993: Make App Groups SQLite path a default one. Implement migration from previous path
Parents
rCOMMc931636cd67c: Enable App Groups in Comm and Notification Service
Branches
Unknown
Tags
Unknown