HomePhabricator
Diffusion Comm aabaad4f147e

[web/native/lib] make `source` param required on log in

Description

[web/native/lib] make source param required on log in

Summary:
Make source param required while calling the server endpoint. (task)

Note: there are still some places where source is optional but it is used in a different context - for now we care only about making it required while connecting with the keyserver, but if it is signification can be refactored in the future to make source required in remaining places.

Test Plan:

  1. Running flow check.
  2. Checking all callers of resolveInvalidatedCookie - it's called only by fetchNewCookieFromNativeCredentials and source was required there previously and everywhere fetchNewCookieFromNativeCredentials is called source is passed explicitly from loginActionSources.

Reviewers: tomek, atul, ashoat

Reviewed By: ashoat

Subscribers: ashoat, atul, abosh

Differential Revision: https://phab.comm.dev/D5259

Details

Provenance
kamilAuthored on Sep 29 2022, 3:08 AM
Reviewer
ashoat
Differential Revision
D5259: [web/native/lib] make `source` param required on log in
Parents
rCOMMf6382b311477: [native/keyserver] add `source` param on log in from native
Branches
Unknown
Tags
Unknown