HomePhabricator
Diffusion Comm ab389ba6796c

[web] Remove admins tab when there are no admins

Tags
None
Referenced Files
F2726584: without admins.png
Sep 18 2024, 7:03 AM
File Not Attached
F2726583: with admins.png
Sep 18 2024, 7:03 AM
File Not Attached
Subscribers
None

Description

[web] Remove admins tab when there are no admins

Summary:
In thick threads there are no admins, so it doesn't make sense to show an empty tab. Instead of hiding the tab just for thick threads, we can hide the tab every time there are no admins.

with admins.png (778×514 px, 32 KB)

without admins.png (1×1 px, 192 KB)

https://linear.app/comm/issue/ENG-9258/remove-admins-tab-in-thick-threads

Test Plan: Open a members menu in a thread with some admins and check if both tabs appear. Open it in a thick thread and check if only the members tab is present.

Reviewers: kamil, will

Reviewed By: will

Differential Revision: https://phab.comm.dev/D13359

Details

Provenance
tomekAuthored on Sep 17 2024, 2:20 AM
Reviewer
will
Differential Revision
D13359: [web] Remove admins tab when there are no admins
Parents
rCOMMa80f96b3c214: [lib] Allow reacting and creating sidebars from failed messages in thick threads
Branches
Unknown
Tags
Unknown