HomePhabricator
Diffusion Comm b01e5441ce0d

[lib] Include `specialRole` field in `RoleInfo` for future clients

Tags
None
Referenced Files
F1132440: image.png
Feb 9 2024, 1:01 PM
File Not Attached
F1132438: image.png
Feb 9 2024, 1:01 PM
File Not Attached
Subscribers
None

Description

[lib] Include specialRole field in RoleInfo for future clients

Summary: We include the specialRole field in RoleInfo based on shouldIncludeSpecialRoleFieldInRoles which is determined by a code version check.

Test Plan:
Hard coded shouldIncludeSpecialRoleFieldInRoles to true/false and observed that the specialRole field was included/excluded:

shouldIncludeSpecialRoleFieldInRoles = true:

image.png (658×1 px, 193 KB)

shouldIncludeSpecialRoleFieldInRoles = false:

image.png (648×1 px, 198 KB)

Reviewers: ginsu, tomek

Reviewed By: ginsu

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D10995

Details

Provenance
atulAuthored on Feb 8 2024, 1:37 PM
Reviewer
ginsu
Differential Revision
D10995: [lib] Include `specialRole` field in `RoleInfo` for future clients
Parents
rCOMMee64c3efb470: [native] fix change role modal border radius style
Branches
Unknown
Tags
Unknown