HomePhabricator
Diffusion Comm b0ce5bba9ba0

[terraform] remove unnecessary redeploy

Description

[terraform] remove unnecessary redeploy

Summary:
These parts of the script are no longer necessary as they are taken care of by
the terraform apply. Originally had the redeployment to take care of redeploying
the primary service after all nodes were taken down, but terraform apply already restores 1 desired node for primary.

Additionally, when the image is updated to a new one (which currently is assumed to cause a migration), local provisioner logic
in the terraform apply will ensure that the primary service is available before the secondary service is launched

Depends on D13094

Test Plan: ran the script and confirmed migration occurred successfully and secondary nodes only applied after primary node was healthy

Reviewers: varun, bartek

Reviewed By: varun

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D13095

Details

Provenance
willAuthored on Aug 15 2024, 5:36 PM
Reviewer
varun
Differential Revision
D13095: [terraform] remove unnecessary redeploy
Parents
rCOMM431156bb46bc: [terraform] increase max time for curl
Branches
Unknown
Tags
Unknown