HomePhabricator
Diffusion Comm b6ba762432c9

[lib] introduced action field to reaction type

Description

[lib] introduced action field to reaction type

Summary:
introduced action field to the reaction type. action is an enum that describes whether the reaction in the reaction field is being added or removed with the values add_reaction and remove_reaction from the target message. I believe this should address the concerns from yesterday's discussion about designing reactions in a more flexible way that allows us to enable multiple reactions (like slack/discord) in the future.


Linear Task: ENG-2244

Test Plan:
flow, and nothing crashes locally on native/web. also tested adding this field with the exisiting message liking infrastructure in my local stack and was able to get unsettingReaction to appear in the DB.

Screenshot 2022-12-05 at 4.21.35 PM.png (1×3 px, 1 MB)

Reviewers: atul, tomek, ashoat, rohan

Reviewed By: atul, tomek, ashoat

Subscribers: ashoat, tomek, atul

Differential Revision: https://phab.comm.dev/D5801

Details

Provenance
ginsuAuthored on Dec 7 2022, 7:21 AM
Reviewer
atul
Differential Revision
D5801: [lib] introduced action field to reaction type
Parents
rCOMM453b74bf6d6b: [web] Add unread indicator within subchannel model
Branches
Unknown
Tags
Unknown