HomePhabricator
Diffusion Comm b7065e9f0580

Implement message typoes validator and import it in root.react.js for side…

Description

Implement message typoes validator and import it in root.react.js for side effect

Summary:
This differential itroduces a file with custom code that checks if all message specs that might generate notifications are implemented in C++ as well. In the case of missing C++ message spec an dalert is displayed. Additionally this
feature required us to alter MessageSpec type a little bit so that generatesNotifs field is now optional.

Test Plan: Build the app and launch it. Ensure alert is not displayed. Go to message-types-validator.js file and comment the check for generatesNotifs in message spec. Now an alert with 5 message types should be displayed.

Reviewers: tomek, atul, bartek

Reviewed By: tomek

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D8103

Details

Provenance
marcinAuthored on Jun 6 2023, 3:08 AM
Reviewer
tomek
Differential Revision
D8103: Implement message typoes validator and import it in root.react.js for side effect
Parents
rCOMM2ae9682a129a: Export CommConstants HostObject to JavaScript
Branches
Unknown
Tags
Unknown