HomePhabricator
Diffusion Comm cbb7f99c7483

[native] Rename resolve-invalidated-cookie.js

Description

[native] Rename resolve-invalidated-cookie.js

Summary:
In a recent diff I renamed the function exported by this file to resolveKeyserverSessionInvalidationUsingNativeCredentials. That's a bit wordy for a filename, but I wanted to rename the file to something that indicates that it uses the legacy password-based keyserver login method.

Depends on D10690

Test Plan:
I tested this stack using the following procedure:

  1. I tested primarily on native
    1. I compiled a dev build and deployed it to an iOS simulator
    2. I created a brand new account on my local keyserver using the iOS app
    3. I ran Redux dev tools: cd native && yarn redux-devtools
    4. I added a 30s sleep at the start of resolveKeyserverSessionInvalidation
    5. I made KeyserverConnectionsHandler return null so that the socket wouldn’t automatically recover the session prior to my testing
    6. I killed the app
    7. I deleted all of the test user’s cookie
    8. I then opened the app again and navigated to a chat and sent two messages
    9. By following the Redux monitor, I was able to see that the keyserver session invalidation recovery was successful, and both messages were eventually sent after the 30s sleep concluded
  2. On web, we don’t support keyserver session invalidation. However, I tested to make sure that the web app still loaded after my changes

Reviewers: tomek, inka, atul

Reviewed By: tomek

Differential Revision: https://phab.comm.dev/D10691

Details

Provenance
ashoatAuthored on Jan 12 2024, 10:15 AM
Reviewer
tomek
Differential Revision
D10691: [native] Rename resolve-invalidated-cookie.js
Parents
rCOMM33827030930d: [lib] Fix type of getInitialNotificationsEncryptedMessage when passed to…
Branches
Unknown
Tags
Unknown