HomePhabricator
Diffusion Comm cc4bf592084a

[backup client] Downloading logs

Description

[backup client] Downloading logs

Summary:
Implemented a backup client function that handles downloading the logs, taking into account network failures, missing logs etc. and retrying the download in case of failure. The tests have been rewritten to use this new function. I considered handling the missing logs better (maybe try and batch them etc.) but because websocket connection is bsaed on TCP, this should be an issue (my testing also showed no problems with this).

Removed the code on native as it will be completely changed anyways in the future diffs.

Added tokio as a dependency, but we already use this exact version, and as you can see from the lock files, there is no actual change in the used dependencies (both commtest and native already depended on tokio).

Depends on D10985

Test Plan: Run the updated integration test. Also tested if the connection is retried in case of any errors.

Reviewers: marcin, bartek, kamil

Reviewed By: bartek

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D10986

Details

Provenance
Michal Gniadek <michal.gniadek@swmansion.com>Authored on Jan 17 2024, 5:06 AM
Reviewer
bartek
Differential Revision
D10986: [backup client] Downloading logs
Parents
rCOMM1361796b7f3f: [backup client] Refactor ws creation
Branches
Unknown
Tags
Unknown

Event Timeline

Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMcc4bf592084a: [backup client] Downloading logs (authored by Michal Gniadek <michal.gniadek@swmansion.com>).Feb 23 2024, 9:01 AM