HomePhabricator
Diffusion Comm cdad23dbed9c

[native] Lift `searchUsers` and `onChangeSearchText` to…

Description

[native] Lift searchUsers and onChangeSearchText to ConnectedChatThreadList

Summary:
(I initially had a huge diff that converted ChatThreadList to a functional component and added various memoizations. However, I realized that diff would be pretty difficult to review so I'm breaking down the refactor into hopefully easier to review pieces.)

This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.

In subsequent diffs will

  1. Lift up "search-related" JSX
  2. etc.. continue turning ChatThreadList into a functional component so we can more precisely memoize things, particularly ChatThreadListItems.

Depends on D9133

Test Plan: Search experience continues to work as expected. Can search for users/threads/etc. as before.

Reviewers: ginsu, tomek, rohan

Reviewed By: ginsu

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D9134

Details

Provenance
atulAuthored on Sep 11 2023, 2:14 PM
Reviewer
ginsu
Differential Revision
D9134: [native] Lift `searchUsers` and `onChangeSearchText` to `ConnectedChatThreadList`
Parents
rCOMMd8217f680e65: [native] Lift `searchCancelButton*` `Value`/`Node`s to…
Branches
Unknown
Tags
Unknown