HomePhabricator
Diffusion Comm ce0bcaa4796e

[keyserver] Pass all variables in .env to Node keyserver

Description

[keyserver] Pass all variables in .env to Node keyserver

Summary:
Otherwise only the ones listed in the environment: section will be included. I think it's safe to forward all of these, and I figure it's not worth individually listing every JSON config name here.

You might ask what the point of leaving COMM_MYSQL_DATABASE, COMM_MYSQL_USER and COMM_MYSQL_PASSWORD is. I figure it's better for discoverability to list these explicitly here, as they are required for the database to initialize and the Node keyserver to run.

Depends on D4173

Test Plan:
I set up a keyserver/.env that looks like this:

COMM_MYSQL_DATABASE=commdev
COMM_MYSQL_USER=commdev
COMM_MYSQL_PASSWORD=pass
COMM_JSONCONFIG_facts_landing_url='{"baseDomain":"http://localhost","basePath":"/commlanding/","baseRoutePath":"/commlanding/","https":false}'
COMM_JSONCONFIG_facts_commapp_url='{"baseDomain":"http://localhost","basePath":"/comm/","https":false,"baseRoutePath":"/comm/"}'

Without this diff, the COMM_JSONCONFIG environmental variables weren't being passed in.

Reviewers: palys-swm, atul

Reviewed By: atul

Subscribers: Adrian, yayabosh

Differential Revision: https://phabricator.ashoat.com/D4174

Details

Provenance
ashoatAuthored on May 31 2022, 11:37 PM
Reviewer
atul
Differential Revision
D4174: [keyserver] Pass all variables in .env to Node keyserver
Parents
rCOMMa009efa9742c: [keyserver] Allow listening address to be configured
Branches
Unknown
Tags
Unknown