HomePhabricator
Diffusion Comm cf4fd35e30c5

[web] [refactor] move hasUsername logic to variable

Tags
None
Referenced Files
F25114: Image 2022-03-23 at 4.05.10 PM.jpg
Mar 25 2022, 11:16 AM
F25115: Image 2022-03-23 at 4.05.25 PM.jpg
Mar 25 2022, 11:16 AM
Subscribers
None

Description

[web] [refactor] move hasUsername logic to variable

Summary:
move logic to variable thats descriptive of what it checks for

Image 2022-03-23 at 4.05.10 PM.jpg (1×3 px, 350 KB)

Image 2022-03-23 at 4.05.25 PM.jpg (2×2 px, 363 KB)

Test Plan: no new added functionality, username should render as normal

Reviewers: atul, palys-swm, def-au1t, ashoat

Reviewed By: ashoat

Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga

Differential Revision: https://phabricator.ashoat.com/D3508

Details

Provenance
benschacAuthored on Mar 25 2022, 10:59 AM
Reviewer
ashoat
Differential Revision
D3508: [web] [refactor] move hasUsername logic to variable
Parents
rCOMM426e725ba042: [web] [refactor] simplify username logic in message preview
Branches
Unknown
Tags
Unknown