HomePhabricator
Diffusion Comm d2a3eecf5dca

[web] Clean up `NotificationsModal` SVG assets and remove `SWMansionIcon`…

Tags
None
Referenced Files
F56220: Screen Shot 2022-05-15 at 10.09.18 AM.png
May 17 2022, 8:37 AM
F56221: Screen Shot 2022-05-15 at 10.09.04 AM.png
May 17 2022, 8:37 AM
Subscribers
None

Description

[web] Clean up NotificationsModal SVG assets and remove SWMansionIcon dependency

Summary:
Linear issue: https://linear.app/comm/issue/ENG-1141/use-svg-instead-of-swmansionicon-in-notificationsmodal

We were previously including the SVG illustrations in NotificationsModal via SWMansionIcon which requires going through the whole "IcoMoon" process. As noted in the Linear issue, the illustrations didn't look great (especially on Safari).

Exported the icons from Figma as SVG, cleaned up the vectors in Sketch, re-exported the cleaned-up illustrations as SVG, uploaded to S3, and replaced SWMansionIcon with <img> in NotificationsModal.

Before:

Screen Shot 2022-05-15 at 10.09.18 AM.png (1×844 px, 101 KB)

After:

Screen Shot 2022-05-15 at 10.09.04 AM.png (1×844 px, 100 KB)

Test Plan: Ensured that the illustrations looked as expected on Safari, Chrome, and Firefox.

Reviewers: def-au1t, palys-swm, benschac

Reviewed By: palys-swm

Subscribers: ashoat, Adrian, yayabosh

Differential Revision: https://phabricator.ashoat.com/D4041

Details

Provenance
atulAuthored on May 15 2022, 7:12 AM
Reviewer
tomek
Differential Revision
D4041: [web] Clean up `NotificationsModal` SVG assets and remove `SWMansionIcon` dependency
Parents
rCOMM4b8c8de82fb2: [docs] Remove Python 2 installation steps
Branches
Unknown
Tags
Unknown