HomePhabricator
Diffusion Comm d3271a251de4

[native] Disable CryptoModule copy construction

Description

[native] Disable CryptoModule copy construction

Summary:
See explanation here for why it's unsafe to copy-construct CryptoModule. Basically, the accountBuffer contains memory that represents an olm::Account, which includes members that are olm::Lists. olm::Lists contains a member that is a pointer to another member, which makes it unsafe to copy the accountBuffer wholesale.

Depends on D9561

Test Plan: I confirmed that after I saw compilation errors if I reverted the preceding diff (D9561)

Reviewers: marcin, tomek, bartek, atul

Reviewed By: marcin

Subscribers: wyilio

Differential Revision: https://phab.comm.dev/D9562

Details

Provenance
ashoatAuthored on Oct 22 2023, 8:50 AM
Reviewer
marcin
Differential Revision
D9562: [native] Disable CryptoModule copy construction
Parents
rCOMMf09476d7d52e: [native] Avoid copy-constructing CryptoModule
Branches
Unknown
Tags
Unknown