HomePhabricator
Diffusion Comm d5bde70ac237

[landing] Remove `font-size` in `global.css:html`

Description

[landing] Remove font-size in global.css:html

Summary:
We don't want to set a changing font-size in the root (html selector) because that affects what 1rem is downstream. My understanding is that the root should have 1rem = 16px unless the user modifies their browser settings. We should hold this constant and modify font-size dynamically for <p>, <h1>, etc. because they won't all necessarily scale together linearly. This should make the math simpler.

Subsequent diffs will fix things for each element.

Test Plan: NA, observed that 1rem = 16px

Reviewers: benschac, palys-swm, ashoat

Reviewed By: benschac, ashoat

Subscribers: Adrian, karol-bisztyga

Differential Revision: https://phabricator.ashoat.com/D3430

Details

Provenance
atulAuthored on Mar 15 2022, 8:42 AM
Reviewer
benschac
Differential Revision
D3430: [landing] Remove `font-size` in `global.css:html`
Parents
rCOMM2e0df3b75821: [web] [chore] add all remaining icons that haven't been imported
Branches
Unknown
Tags
Unknown